Skip to content

ci: fail the notify job when the announcement is rejected - #2040

Merged
zimeg merged 1 commit into
mainfrom
notify-errors-true
Nov 14, 2026
Merged

zimeg merged 1 commit into
mainfrom
notify-errors-true

Conversation

@zimeg

@zimeg zimeg commented Nov 13, 2026

Copy link
Copy Markdown
Member

Summary

This pull request sets errors: true on the release announcement step, so a webhook that rejects the post fails the notify job instead of logging an error and staying green.

         uses: slackapi/slack-github-action@dcb1066f776dd043e64d0e8ba94ca15cc7e1875d # v4.0.0
         with:
+          errors: true
           webhook: ${{ secrets.SLACK_RELEASE_ANNOUNCEMENTS_WEBHOOK_URL }}

Testing

  • On the next release, confirm the announcement posts and the notify job stays green.

Category

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs (Documents)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

🤖 Generated with Claude Code

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
@zimeg
zimeg requested a review from a team as a code owner November 13, 2026 23:58
@zimeg zimeg added this to the 3.47.1 milestone Nov 13, 2026
@zimeg zimeg added the github_actions Pull requests that update GitHub Actions code label Nov 13, 2026
@zimeg zimeg self-assigned this Nov 13, 2026
@codecov

codecov Bot commented Nov 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.43%. Comparing base (2277901) to head (f08ca6d).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2040   +/-   ##
=======================================
  Coverage   84.43%   84.43%           
=======================================
  Files         118      118           
  Lines       14034    14034           
=======================================
  Hits        11849    11849           
  Misses       2185     2185           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@mwbrooks mwbrooks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Thanks @zimeg! Failing loudly on a rejected post means a revoked webhook shows up on the release run instead of hiding in a warning.

@zimeg

zimeg commented Nov 14, 2026

Copy link
Copy Markdown
Member Author

🐍 Thanks for the kind review @mwbrooks! Rejected posts will show up on the release run now 🔔

@zimeg
zimeg merged commit 113f67d into main Nov 14, 2026
19 checks passed
@zimeg
zimeg deleted the notify-errors-true branch November 14, 2026 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants